Fix tests#112
Merged
chrisbrahms merged 9 commits intoLupoLab:masterfrom Apr 1, 2020
Merged
Conversation
jtravs
reviewed
Apr 1, 2020
Contributor
jtravs
left a comment
jtravs
left a comment
There was a problem hiding this comment.
In general this all makes sense. But I really don't like the terminology of passing in β1. I much prefer passing a velocity and working out why that was an issue.
| end | ||
|
|
||
| function make_const_linop(grid::Grid.RealGrid, βfun!, αfun!, frame_vel) | ||
| function make_const_linop(grid::Grid.RealGrid, βfun!, αfun!, β1) |
Contributor
There was a problem hiding this comment.
I know why your doing this, but it kind of removes generality. There are cases where we want a different frame velocity, and it seems weird to have to pass the inverse.
Collaborator
Author
Contributor
There was a problem hiding this comment.
OK, I'm happy with that. Perhaps open an issue to keep track.
| @test isapprox(p.Lfiss, 1.768) | ||
| @test isapprox(p.zdw, 378.8e-9) | ||
| @test isapprox(p.P0/p.Pcr, 0.0398) | ||
| @test isapprox(p.N, 2.239, rtol=1e-2) |
Contributor
There was a problem hiding this comment.
I'm sure I had these tolerances in there just a few days ago. But then again I've been sure of many untrue things recently.
jtravs
approved these changes
Apr 1, 2020
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes various small things that were messed up when merging #99 and #109 as well as the issue flagged up here
Notes:
test_capillary.jlandtest_maths.jlare now marked as broken. They will error if/when they pass again.test_tools.jlfailed and I couldn't find a point where they passed. This makes sense to me as the comparison values only had 3 significant digits and theisapproxcomparisons had no tolerances specified. Did these pass at some point in the state currently onmaster?